Repository navigation
fix(google): remove the shut-down veo-3.1-generate-preview registration - #585
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
veo-3.1-generate-previewis the last Veo id in the Google videos catalog, and the Gemini API no longer serves it. The Veo 3.1 page says: "Veo 3.1 Preview (veo-3.1-generate-preview,veo-3.1-fast-generate-preview, andveo-3.1-lite-generate-preview) in the Gemini API was shut down on October 22, 2026. Migrate to Gemini Omni Flash (gemini-omni-1.2-flash) or the GA models available through the Gemini Enterprise Agent Platform to avoid service interruptions." The deprecations table listsveo-3.1-generate-previewwith shutdown "October 22, 2026" and replacementgemini-omni-1.2-flash. On Google Cloud, the Veo 3.1 page lists onlyveo-3.1-generate-001,veo-3.1-fast-generate-001andveo-3.1-lite-generate-001, not the preview id. CLAUDE.md: "Remove a model id only after a live authenticated call hard-rejects it". It does now (see Validation). #550 and #552 removed the other two Veo 3.1 preview ids the same way.Fix:
src/celeste/modalities/videos/providers/google/models.py: drop theveo-3.1-generate-previewentry, soGOOGLE_VEO_MODELSis empty.tests/unit_tests/test_google_videos_interactions.py: the Veo dispatch test patches_VEO_MODEL_IDSwith a test id, so it still asserts thatGoogleVideosClientselectsGoogleVeoVideosClientand copies its endpoints. The Veo parse test buildsGoogleVeoVideosClientdirectly with a test-localModel.tests/unit_tests/test_google_transport.py: the download credential-scoping test is parametrized over the two backend classes (GoogleVeoVideosClient,GoogleInteractionsVideosClient) with a test-localModel, instead ofcreate_clientwith catalog ids. Both download paths stay covered.tests/unit_tests/test_vertex_routing.pyis unchanged. It builds a test-localModel, the id there is only a URL fragment, and the file already uses ids that are no longer in the catalog (e.g.deepseek-chat, fix: provider bugs and catalog corrections from model-watch findings #314).Left for the maintainer: the Veo route stays:
veo.py,GOOGLE_VEO_PARAMETER_MAPPERS,GOOGLE_SUPPORTED_MIME_TYPES, the dispatcher branch andceleste.providers.google.veo. WithGOOGLE_VEO_MODELSempty, no model id reaches that branch. An unregistered Veo id passed tocreate_clientalready raised "Unknown Google videos model" before this PR. The open decision is whether to keep Veo as a Google Cloud-only route, registering the GA ids above after a live Vertex call, or to delete the route.Validation:
make cipasses (763 unit tests).GoogleVideosClient.generate(prompt="A cat walking", duration=4, resolution="720p")onveo-3.1-generate-preview(strategyGoogleVeoVideosClient).POST /v1beta/models/veo-3.1-generate-preview:predictLongRunningreturned 404NOT_FOUND: "models/veo-3.1-generate-preview is not found for API version v1beta, or is not supported for predictLongRunning."GET /v1beta/modelslists no Veo model, onlygemini-omni-flash-preview,gemini-omni-1.1-flashandgemini-omni-1.2-flash.aiplatform.endpoints.predict("or it may not exist"). The Google Cloud page above does not list the id.